FIX: Optionally linkify URL columns server-side #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup da1c99e We already had the functionality to convert results like this: ``` |blah_url| |--------| |3,https://test.com| ``` To a link clientside, so in the UI it looks like this: ``` <a href="https://test.com">3</a> ``` With the addition of the recurring report to post automation, and the existing report to PM automation, we also need to be able to do this server-side, so reports don't come out malformed if they have these type of count + URL columns.
martin-brennan
force-pushed
the
issue/linkify-counts-url-field
branch
from
a12e2c5 to
6458350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup da1c99e
We already had the functionality to convert results like
this:
To a link clientside, so in the UI it looks like this:
With the addition of the recurring report to post automation,
and the existing report to PM automation, we also need to be
able to do this server-side, so reports don't come out malformed
if they have these type of count + URL columns.
Now if one of the automations generates the report, we tell the report
generator and markdown renderer to create an actual markdown link
for these URL columns.