UX: Rewrite param-input using FormKit #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What does this PR do? ===================== This PR refactors param-input to use FormKit. FormKit is a structured form tool in the core. After the rewrite, we will be able to gradually abandon custom validators, get semantic parameter error prompts, etc. meta link: https://meta.discourse.org/t/wishlist-param-dropdown-for-data-explorer-query/253883/28?u=lhc_fl
nattsw
reviewed
Aug 15, 2024
| @@ -24,9 +24,17 @@ export default class Query extends RestModel { | |||
| return getURL(`/admin/plugins/explorer/queries/${this.id}.json?export=1`); | |||
| } | |||
|
|
|||
| @computed("param_info") | |||
| @computed("param_info", "updateing") | |||
nattsw
reviewed
Aug 15, 2024
In the screenshot, topic_id and string_list are empty, but one of them is a proper error and one is not. Is this intended? |
|
There's a parse error now when group_id is 1. 
|
|
Is this a pre-existing bug? It seems to be a backend behavior, I have not changed this part. upd: I can reproduce it in main branch, I think we should fix this in another PR should fix by #308 |
Lhcfl
added a commit
that referenced
this pull request
Aug 15, 2024
We used `with_deleted` incorrectly in the code. This method does not exist on `User`, `Badge`, and `Group`. This will cause an error when entering a numeric id in these three parameter input, forcing the user to enter the name/username of these inputs. See #307 (comment)
Lhcfl
added a commit
that referenced
this pull request
Aug 15, 2024
We used `with_deleted` incorrectly in the code. This method does not exist on `User`, `Badge`, and `Group`. This will cause an error when entering a numeric id in these three parameter input, forcing the user to enter the name/username of these inputs. See #307 (comment)
…plorer into ux-param-input-formkit-rewrite
jjaffeux
reviewed
Aug 16, 2024
Comment on lines
+305
to
+325
| <Form | ||
| @data={{this.data}} | ||
| @onRegisterApi={{this.onRegisterApi}} | ||
| @onSubmit={{this.onSubmit}} | ||
| class="params-form" | ||
| as |form| | ||
| > | ||
| {{#each this.paramInfo as |info|}} | ||
| <div class="param"> | ||
| <form.Field | ||
| @name={{info.identifier}} | ||
| @title={{info.identifier}} | ||
| @validation={{info.validation}} | ||
| @validate={{info.validate}} | ||
| as |field| | ||
| > | ||
| <info.component @field={{field}} @info={{info}} /> | ||
| </form.Field> | ||
| </div> | ||
| {{/each}} | ||
| </Form> |
There was a problem hiding this comment.
Im impressed, you have greatly managed to integrate form kit into something which is not "standard" at all 👏
nattsw
reviewed
Aug 19, 2024
nattsw
reviewed
Aug 19, 2024
nattsw
reviewed
Aug 19, 2024
nattsw
reviewed
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors param-input to use FormKit. FormKit is a structured form tool in the core. After the rewrite, we will be able to gradually abandon custom validators, get semantic parameter error prompts, etc.
meta link: https://meta.discourse.org/t/wishlist-param-dropdown-for-data-explorer-query/253883/28?u=lhc_fl
Screenshot