FEATURE: Allow topic URL without post number for post_id param #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
commented
Jan 12, 2024
| @@ -67,6 +67,46 @@ def self.type_aliases | |||
| @type_aliases ||= { integer: :int, text: :string, timestamp: :datetime } | |||
| end | |||
|
|
|||
| def self.create_from_sql(sql, opts = {}) | |||
There was a problem hiding this comment.
This was just moved around so the class + instance methods are grouped properly
martin-brennan
commented
Jan 12, 2024
| @@ -173,9 +205,13 @@ def invalid_format(string, msg = nil) | |||
| invalid_format string, "The user named #{string} was not found" | |||
| end | |||
| elsif type == :post_id | |||
| if string =~ %r{(\d+)/(\d+)(\?u=.*)?$} | |||
| if string =~ %r{/t/[^/]+/(\d+)(\?u=.*)?$} | |||
There was a problem hiding this comment.
Main change is here
martin-brennan
force-pushed
the
feature/allow-topic-url-in-post-id-param
branch
from
0126826 to
96d79db
Compare
This commit allows base topic URLs (e.g. https://meta.discourse.org/t/hide-text-in-text-select-popup-menu-feedback/287656) to be used by the post_id parameter type. We just assume in this case that the post_id for the param is 1.
martin-brennan
force-pushed
the
feature/allow-topic-url-in-post-id-param
branch
from
96d79db to
fa7dfda
Compare
tgxworld
approved these changes
Jan 16, 2024
|
Thanks @tgxworld ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows base topic URLs (e.g. https://meta.discourse.org/t/hide-text-in-text-select-popup-menu-feedback/287656)
to be used by the post_id parameter type. We just assume in this case
that the post_id for the param is 1.