revert parameter change

discourse · Aug 20, 2024 · f33015f · f33015f
1 parent 37674a1
commit f33015f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/discourse_data_explorer/parameter.rb b/lib/discourse_data_explorer/parameter.rb
@@ -4,7 +4,7 @@ module ::DiscourseDataExplorer
   class Parameter
     attr_accessor :identifier, :type, :default, :nullable
 
-    def initialize(identifier, type, default, nullable, check: true)
+    def initialize(identifier, type, default, nullable)
       unless identifier
         raise ValidationError.new("Parameter declaration error - identifier is missing")
       end
@@ -25,7 +25,7 @@ def initialize(identifier, type, default, nullable, check: true)
       @default = default
       @nullable = nullable
       begin
-        cast_to_ruby default if default.present? && check
+        cast_to_ruby default if default.present?
       rescue ValidationError
         raise ValidationError.new(
                 "Parameter declaration error - the default value is not a valid #{type}",
@@ -89,7 +89,7 @@ def self.create_from_sql(sql, opts = {})
             type = type.strip
 
             begin
-              ret_params << Parameter.new(ident, type, default, nullable, check: false)
+              ret_params << Parameter.new(ident, type, default, nullable)
             rescue StandardError
               raise if opts[:strict]
             end