DEV: Update linting (#338)

discourse · Nov 20, 2024 · efb7f36 · efb7f36
1 parent 3a58ba6
commit efb7f36
Show file tree

Hide file tree

Showing 7 changed files with 247 additions and 257 deletions.
diff --git a/assets/javascripts/discourse/components/data-explorer-bar-chart.js b/assets/javascripts/discourse/components/data-explorer-bar-chart.js
@@ -11,6 +11,11 @@ export default class DataExplorerBarChart extends Component {
   gridColor = themeColor("--primary-low");
   labelsColor = themeColor("--primary-medium");
 
+  willDestroy() {
+    super.willDestroy(...arguments);
+    this.chart.destroy();
+  }
+
   get config() {
     const data = this.data;
     const options = this.options;
@@ -84,9 +89,4 @@ export default class DataExplorerBarChart extends Component {
     this.chart.data = this.data;
     this.chart.update();
   }
-
-  willDestroy() {
-    super.willDestroy(...arguments);
-    this.chart.destroy();
-  }
 }
diff --git a/assets/javascripts/discourse/components/query-result.js b/assets/javascripts/discourse/components/query-result.js
@@ -186,15 +186,19 @@ export default class QueryResult extends Component {
   lookupUser(id) {
     return this.transformedUserTable[id];
   }
+
   lookupBadge(id) {
     return this.transformedBadgeTable[id];
   }
+
   lookupPost(id) {
     return this.transformedPostTable[id];
   }
+
   lookupTopic(id) {
     return this.transformedTopicTable[id];
   }
+
   lookupGroup(id) {
     return this.transformedGroupTable[id];
   }

diff --git a/assets/javascripts/discourse/models/query.js b/assets/javascripts/discourse/models/query.js
@@ -33,6 +33,7 @@ export default class Query extends RestModel {
   beforeUpdate() {
     this.set("updateing", true);
   }
+
   afterUpdate() {
     this.set("updateing", false);
   }

diff --git a/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs b/assets/javascripts/discourse/templates/admin/plugins-explorer.hbs
@@ -159,7 +159,7 @@
           {{else}}
             <div class="sql">
               <CodeView
-                @value={{selectedItem.sql}}
+                @value={{this.selectedItem.sql}}
                 @codeClass="sql"
                 @setDirty={{this.setDirty}}
               />

diff --git a/assets/javascripts/discourse/templates/group-reports-index.hbs b/assets/javascripts/discourse/templates/group-reports-index.hbs
@@ -17,7 +17,7 @@
           <td>
             <LinkTo
               @route="group.reports.show"
-              @models={{array group.name query.id}}
+              @models={{array this.group.name query.id}}
             >
               {{query.name}}
             </LinkTo>

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "private": true,
   "devDependencies": {
-    "@discourse/lint-configs": "2.0.1",
+    "@discourse/lint-configs": "2.2.0",
     "ember-template-lint": "6.0.0",
     "eslint": "9.14.0",
     "prettier": "2.8.8"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml