Skip to content

Commit

Permalink
DEV: Update linting (#276)
Browse files Browse the repository at this point in the history
  • Loading branch information
CvX authored Jan 15, 2024
1 parent 66c54a3 commit 31ebf69
Show file tree
Hide file tree
Showing 7 changed files with 158 additions and 103 deletions.
24 changes: 9 additions & 15 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ GEM
ast (2.4.2)
json (2.7.1)
language_server-protocol (3.17.0.3)
parallel (1.23.0)
parser (3.2.2.4)
parallel (1.24.0)
parser (3.3.0.3)
ast (~> 2.4.1)
racc
prettier_print (1.2.1)
racc (1.7.3)
rainbow (3.1.1)
regexp_parser (2.8.3)
regexp_parser (2.9.0)
rexml (3.2.6)
rubocop (1.59.0)
json (~> 2.3)
Expand All @@ -26,14 +26,14 @@ GEM
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.30.0)
parser (>= 3.2.1.0)
rubocop-capybara (2.19.0)
rubocop-capybara (2.20.0)
rubocop (~> 1.41)
rubocop-discourse (3.5.0)
rubocop-discourse (3.6.0)
rubocop (>= 1.59.0)
rubocop-rspec (>= 2.25.0)
rubocop-factory_bot (2.24.0)
rubocop (~> 1.33)
rubocop-rspec (2.25.0)
rubocop-factory_bot (2.25.1)
rubocop (~> 1.41)
rubocop-rspec (2.26.1)
rubocop (~> 1.40)
rubocop-capybara (~> 2.17)
rubocop-factory_bot (~> 2.22)
Expand All @@ -43,17 +43,11 @@ GEM
unicode-display_width (2.5.0)

PLATFORMS
arm64-darwin-20
arm64-darwin-22
ruby
x86_64-darwin-18
x86_64-darwin-19
x86_64-darwin-20
x86_64-linux

DEPENDENCIES
rubocop-discourse
syntax_tree

BUNDLED WITH
2.3.10
2.5.4
4 changes: 2 additions & 2 deletions assets/javascripts/discourse/components/explorer-schema.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<DButton
@action={{this.expandSchema}}
@icon="chevron-left"
@class="no-text unhide"
class="no-text unhide"
/>
{{else}}
<div class="schema">
Expand All @@ -14,7 +14,7 @@
<DButton
@action={{this.collapseSchema}}
@icon="chevron-right"
@class="no-text"
class="no-text"
/>
</div>

Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/components/share-report.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@

<DButton
@action={{this.close}}
@class="btn-flat close"
@icon="times"
@aria-label="share.close"
@title="share.close"
class="btn-flat close"
/>
</div>
{{/if}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
<DButton
@action={{this.displayCreate}}
@icon="plus"
@class="no-text btn-right"
class="no-text btn-right"
/>
<PickFilesButton
@class="import-btn"
@label="explorer.import.label"
@icon="upload"
@acceptedFormatsOverride={{this.acceptedImportFileTypes}}
@showButton="true"
@onFilesPicked={{this.import}}
class="import-btn"
/>
</div>

Expand Down Expand Up @@ -56,12 +56,12 @@
<DButton
@action={{this.goHome}}
@icon="chevron-left"
@class="previous"
class="previous"
/>
<DButton
@action={{this.exitEdit}}
@icon="times"
@class="previous"
class="previous"
/>
<div class="name-text-field">
<TextField
Expand All @@ -83,7 +83,7 @@
<DButton
@action={{this.goHome}}
@icon="chevron-left"
@class="previous"
class="previous"
/>

<h1>
Expand Down Expand Up @@ -217,9 +217,9 @@

<DButton
@action={{this.destroyQuery}}
@class="btn-danger"
@icon="trash-alt"
@label="explorer.delete"
class="btn-danger"
/>
{{/if}}
</div>
Expand All @@ -242,14 +242,14 @@
<DButton
@label="explorer.run"
@disabled="true"
@class="btn-primary"
class="btn-primary"
/>
{{else}}
<DButton
@action={{this.saveAndRun}}
@icon="play"
@label="explorer.saverun"
@class="btn-primary"
class="btn-primary"
/>
{{/if}}
{{else}}
Expand All @@ -258,8 +258,8 @@
@icon="play"
@label="explorer.run"
@disabled={{this.runDisabled}}
@class="btn-primary"
@type="submit"
class="btn-primary"
/>
{{/if}}

Expand Down
4 changes: 2 additions & 2 deletions assets/javascripts/discourse/templates/group-reports-show.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
@action={{this.run}}
@icon="play"
@label="explorer.run"
@class="btn-primary"
@type="submit"
class="btn-primary"
/>

<DButton
@action={{this.toggleBookmark}}
@label={{this.bookmarkLabel}}
@icon={{this.bookmarkIcon}}
@class={{this.bookmarkClassName}}
class={{this.bookmarkClassName}}
/>
</form>

Expand Down
9 changes: 3 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
{
"name": "discourse-data-explorer",
"version": "0.3.0",
"repository": "https://github.com/discourse/discourse-data-explorer",
"author": "Discourse",
"license": "MIT",
"private": true,
"devDependencies": {
"@discourse/lint-configs": "^1.3.1",
"@discourse/lint-configs": "^1.3.5",
"ember-template-lint": "^5.13.0",
"eslint": "^8.55.0",
"eslint": "^8.56.0",
"prettier": "^2.8.8"
}
}
Loading

0 comments on commit 31ebf69

Please sign in to comment.