Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Rename Custom_header_links settings to custom_header_links #45

Merged
merged 1 commit into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions javascripts/discourse/components/custom-header-links.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@ import { dasherize } from "@ember/string";

export default class CustomHeaderLinks extends Component {
get shouldShow() {
return settings.Custom_header_links?.length > 0;
return settings.custom_header_links?.length > 0;
}

get links() {
return settings.Custom_header_links.split("|").reduce((result, item) => {
return settings.custom_header_links.split("|").reduce((result, item) => {
let [
linkText,
linkTitle,
Expand Down
8 changes: 8 additions & 0 deletions migrations/settings/0001-rename-settings.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export default function migrate(settings) {
if (settings.has("Custom_header_links")) {
settings.set("custom_header_links", settings.get("Custom_header_links"));
settings.delete("Custom_header_links");
}

return settings;
}
2 changes: 1 addition & 1 deletion settings.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Custom_header_links:
custom_header_links:
type: list
list_type: simple
default: "External link, this link will open in a new tab, https://meta.discourse.org, vdo, blank, remove|Most Liked, Posts with the most amount of likes, /latest/?order=op_likes, vdo, self, keep|Privacy, Our Privacy Policy, /privacy, vdm, self, keep"
Expand Down
25 changes: 25 additions & 0 deletions test/unit/migrations/settings/0001-rename-settings-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { module, test } from "qunit";
import migrate from "../../../../migrations/settings/0001-rename-settings";

module("Unit | Migrations | Settings | 0001-rename-settings", function () {
test("migrate", function (assert) {
const settings = new Map(
Object.entries({
Custom_header_links: "some,links",
})
);

const result = migrate(settings);

assert.deepEqual(
Array.from(result),
Array.from(
new Map(
Object.entries({
custom_header_links: "some,links",
})
)
)
);
});
});