FEATURE: display category icon in post body #36
Conversation
This commit allows displaying category icons in the body of the post. Related meta topic: https://meta.discourse.org/t/category-icons-dont-show-up-in-post-text/315851
| if (!color || color?.match(/categoryColo(u*)r/g)) { | ||
| opts.color = `#${cat.color}`; | ||
| } | ||
| slugMap[cat.slug.toLowerCase()] = opts; |
There was a problem hiding this comment.
What happens if there are multiple categories with empty slugs?
(I'm basing this hypothetical off https://github.com/discourse/discourse/blob/main/app/models/category.rb#L688)
There was a problem hiding this comment.
We have a
if (slug && icon) {Therefore, the category with an empty slug will not enter this statement. 😊
| } | ||
| } | ||
| api.decorateCookedElement((elem) => { | ||
| const categorgHashtags = elem.querySelectorAll( |
There was a problem hiding this comment.
(nit) categorgHashtags seems like a typo - maybe categoryHashtags?
| if (match === "partial") { | ||
| if (!cat.slug.toLowerCase().includes(slug.toLowerCase())) { | ||
| continue; | ||
| } | ||
| } else { | ||
| if (cat.slug.toLowerCase() !== slug.toLowerCase()) { | ||
| continue; | ||
| } | ||
| } |
There was a problem hiding this comment.
(minor) perhaps this could be simplified to something a single guard clause?
| if (match === "partial") { | |
| if (!cat.slug.toLowerCase().includes(slug.toLowerCase())) { | |
| continue; | |
| } | |
| } else { | |
| if (cat.slug.toLowerCase() !== slug.toLowerCase()) { | |
| continue; | |
| } | |
| } | |
| if ((match === "partial" && !cat.slug.toLowerCase().includes(slug.toLowerCase())) || cat.slug.toLowerCase() !== slug.toLowerCase()) { | |
| continue | |
| } |
There was a problem hiding this comment.
Probably could DRY out the repeated lowerCase calls too 🤔
|
@tyb-talks Can you review it again for me? I rewrote it using the new API of Discourse instead of calling |
This commit allows displaying category icons in the body of the post.
Screenshots
New setting:
Before change:
After change:
Related meta topic: https://meta.discourse.org/t/category-icons-dont-show-up-in-post-text/315851