add migration logic for category_lock_icon

discourse · Dec 23, 2024 · 4e24b34 · 4e24b34
1 parent 609126c
commit 4e24b34
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/migrations/settings/0001-migrate-from-deprecated-icon-names.js b/migrations/settings/0001-migrate-from-deprecated-icon-names.js
@@ -12,8 +12,9 @@ export default function migrate(settings) {
       return props.join(",");
     },
     svg_icons: (icon) => convertIconName(icon),
+    category_lock_icon: (icon) => convertIconName(icon),
   };
-  const settingNames = ["category_icon_list", "svg_icons"];
+  const settingNames = ["category_icon_list", "svg_icons", "category_lock_icon"];
 
   settingNames.forEach((settingName) => {
     const oldSetting = settings.get(settingName);

diff --git a/test/unit/migrations/settings/0001-migrate-from-deprecated-icon-names-test.js b/test/unit/migrations/settings/0001-migrate-from-deprecated-icon-names-test.js
@@ -1,15 +1,16 @@
 import { module, test } from "qunit";
-import migrate from "../../../../migrations/settings/0001-migrate-from-deprecated-icon-names.js";
+import migrate from "../../../../migrations/settings/0001-migrate-from-deprecated-icon-names";
 
 module(
-  "Unit | Migrations | Settings | 0001-migrate-from-deprecated-icon-names.js",
+  "Unit | Migrations | Settings | 0001-migrate-from-deprecated-icon-names",
   function () {
     test("migrate", function (assert) {
       const settings = new Map(
         Object.entries({
           category_icon_list:
-            "meta,fab-facebook,#CC0000,partial|x,fab-twitter,#CC0011,full|config,fab-cog,#CC0012,partial|group,user-friends,#CC0001,",
+            "meta,fab-facebook,#CC0000,partial|x,fab-twitter,#CC0011,full|config,fab fa-cog,#CC0012,partial|group,user-friends,#CC0001,",
           svg_icons: "fab-facebook|fab-twitter|fab-cog|user-friends",
+          category_lock_icon: "fas fa-lock-alt",
         })
       );
 
@@ -18,8 +19,9 @@ module(
       const expectedResult = new Map(
         Object.entries({
           category_icon_list:
-            "meta,fab-facebook,#CC0000,partial|x,fab-twitter,#CC0011,full|config,fab fa-gear,#CC0012,partial|group,user-group,#CC0001,",
+            "meta,fab-facebook,#CC0000,partial|x,fab-twitter,#CC0011,full|config,fab-gear,#CC0012,partial|group,user-group,#CC0001,",
           svg_icons: "fab-facebook|fab-twitter|fab-gear|user-group",
+          category_lock_icon: "lock-keyhole",
         })
       );
       assert.deepEqual(Array.from(result), Array.from(expectedResult));