Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: pending_assigns_reminder reminder leaking total assigned topics count #617

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Grubba27
Copy link
Contributor

@Grubba27 Grubba27 commented Dec 4, 2024

Before this commit, the reminder leaked the total assigned topics count in the title, which is inconsistent with the UI.

In the post raw, it was ensured that it was not being leaked, but the title was still leaking the count.

Also, add specs and update existing ones to ensure the count is not leaked in the title.

How it was looking before(post.raw) from specs:

You currently have [3 pending assignments](http://test.localhost/u/bruce0/activity/assigned).

### Newest
- [This is a test topic 1](/t/this-is-a-test-topic-1/169) - assigned less than 1 minute ago
- [This is a test topic 0](/t/this-is-a-test-topic-0/168) - assigned less than 1 minute ago

it should be 2 pending assignments

Now:

You currently have [2 pending assignments](http://test.localhost/u/bruce0/activity/assigned).

### Newest
- [This is a test topic 1](/t/this-is-a-test-topic-1/174) - assigned less than 1 minute ago
- [This is a test topic 0](/t/this-is-a-test-topic-0/173) - assigned less than 1 minute ago

It is related to 4630dab

…count

Before this commit, the reminder was leaking the total assigned topics count in the title.

In the post raw it was ensured that it was not being leaked but the title was still leaking the count.

Also add specs and updated existing specs to ensure that the count is not leaked in the title.
Copy link
Contributor

@markvanlan markvanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So good, thank you

@Grubba27 Grubba27 merged commit 1a5091e into main Dec 4, 2024
6 checks passed
@Grubba27 Grubba27 deleted the fix/pending_assigns_reminder-leaking-count branch December 4, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants