Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update tests for core change #525

Merged
merged 1 commit into from
Nov 15, 2023
Merged

DEV: Update tests for core change #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/system/page_objects/modals/assign.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def note=(note)
end

def confirm
find(".modal-footer .btn-primary").click
find(".d-modal__footer .btn-primary").click
end
end
end
Expand Down
6 changes: 3 additions & 3 deletions test/javascripts/acceptance/assigns-tab-user-menu-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,13 @@ acceptance("Discourse Assign | user menu", function (needs) {
assert.false(markRead, "mark-read request isn't sent");
assert.strictEqual(
query(
".dismiss-notification-confirmation .modal-body"
".dismiss-notification-confirmation .d-modal__body"
).textContent.trim(),
I18n.t("notifications.dismiss_confirmation.body.assigns", { count: 173 }),
"dismiss confirmation modal is shown"
);

await click(".modal-footer .btn-primary");
await click(".d-modal__footer .btn-primary");
assert.true(markRead, "mark-read request is sent");
assert.dom(".notifications-dismiss").doesNotExist("dismiss button is gone");
assert
Expand Down Expand Up @@ -312,7 +312,7 @@ acceptance("Discourse Assign | user menu", function (needs) {
await click(".notifications-dismiss");
assert.false(markRead, "a request to the server is not made");
assert
.dom(".dismiss-notification-confirmation .modal-body")
.dom(".dismiss-notification-confirmation .d-modal__body")
.exists("the dismiss notification confirmation modal is present");
});
});
Loading