Skip to content

Commit

Permalink
UX: simplify markup to fix j/k highlighting (#516)
Browse files Browse the repository at this point in the history
This cleans up the markup a bit, so instead of a `div` as a table child we use the `td` and removes the internal wrapper. This fixes an issue with a double highlight while using j/k navigation highlighting caused by the nested `td`.
  • Loading branch information
awesomerobot authored Oct 20, 2023
1 parent 92b0dd5 commit 7fe45c8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { action } from "@ember/object";

export default class AssignedTopicListColumn extends Component {
<template>
<td class="topic-list-data">
{{#if @topic.assigned_to_user}}
<AssignActionsDropdown
@topic={{@topic}}
Expand All @@ -24,7 +23,6 @@ export default class AssignedTopicListColumn extends Component {
{{else}}
<AssignActionsDropdown @topic={{@topic}} @unassign={{this.unassign}} />
{{/if}}
</td>
</template>

@service taskActions;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default class extends EmberObject {
if (ASSIGN_LIST_ROUTES.includes(this.router.currentRouteName)) {
return rawRenderGlimmer(
this,
"div.assign-topic-buttons",
"td.assign-topic-buttons",
<template><AssignedTopicListColumn @topic={{@data.topic}} /></template>,
{ topic: this.topic }
);
Expand Down

0 comments on commit 7fe45c8

Please sign in to comment.