Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: add FontAwesome 6 variants of icon names as keys to mappings #14

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

tyb-talks
Copy link
Contributor

@tyb-talks tyb-talks commented Jan 3, 2025

This PR adds updated Font Awesome icon names to the existing mapping reference files. For more detail on this upgrade, refer to the announcement at https://meta.discourse.org/t/-/325349.

This mapping logic should now be compatible across both deprecated and upgraded sets of FA icon names.

Updating of mappings was done via a script that used the same convertIconName function as in discourse/Discourse-Tiles-image-gallery#29.

@tyb-talks tyb-talks merged commit 845e5f7 into main Jan 3, 2025
@tyb-talks tyb-talks deleted the dev-add-fa6-icon-names-to-mappings branch January 3, 2025 05:07
@pmusaraj
Copy link
Contributor

pmusaraj commented Jan 3, 2025

Awesome, thanks @tyb-talks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants