From ac705b694b179a144b2f07eec7a6dd4ac1e09aa4 Mon Sep 17 00:00:00 2001
From: Kris <kris.aubuchon@discourse.org>
Date: Thu, 19 Dec 2024 18:14:22 -0500
Subject: [PATCH] UX: minor improvements to LLM page and admin tables (#1034)

---
 .../components/ai-llms-list-editor.gjs        | 24 +++++--------
 .../modules/llms/common/ai-llms-editor.scss   | 34 +++++++++++++++++--
 2 files changed, 40 insertions(+), 18 deletions(-)

diff --git a/assets/javascripts/discourse/components/ai-llms-list-editor.gjs b/assets/javascripts/discourse/components/ai-llms-list-editor.gjs
index 820f75e53..0bc82d68d 100644
--- a/assets/javascripts/discourse/components/ai-llms-list-editor.gjs
+++ b/assets/javascripts/discourse/components/ai-llms-list-editor.gjs
@@ -119,14 +119,17 @@ export default class AiLlmsListEditor extends Component {
           @llmTemplate={{@llmTemplate}}
         />
       {{else}}
+        <DPageSubheader
+          @titleLabel={{i18n "discourse_ai.llms.short_title"}}
+          @descriptionLabel={{i18n
+            "discourse_ai.llms.preconfigured.description"
+          }}
+          @learnMoreUrl="https://meta.discourse.org/t/discourse-ai-large-language-model-llm-settings-page/319903"
+        />
         {{#if this.hasLlmElements}}
           <section class="ai-llms-list-editor__configured">
             <DPageSubheader
               @titleLabel={{i18n "discourse_ai.llms.configured.title"}}
-              @descriptionLabel={{i18n
-                "discourse_ai.llms.preconfigured.description"
-              }}
-              @learnMoreUrl="https://meta.discourse.org/t/discourse-ai-large-language-model-llm-settings-page/319903"
             />
             <table class="d-admin-table">
               <thead>
@@ -185,18 +188,7 @@ export default class AiLlmsListEditor extends Component {
           </section>
         {{/if}}
         <section class="ai-llms-list-editor__templates">
-          <DPageSubheader
-            @titleLabel={{i18n this.preconfiguredTitle}}
-            @descriptionLabel={{unless
-              this.hasLlmElements
-              (i18n "discourse_ai.llms.preconfigured.description")
-            }}
-            @learnMoreUrl={{unless
-              this.hasLlmElements
-              "https://meta.discourse.org/t/discourse-ai-large-language-model-llm-settings-page/319903"
-            }}
-          />
-
+          <DPageSubheader @titleLabel={{i18n this.preconfiguredTitle}} />
           <AdminSectionLandingWrapper
             class="ai-llms-list-editor__templates-list"
           >
diff --git a/assets/stylesheets/modules/llms/common/ai-llms-editor.scss b/assets/stylesheets/modules/llms/common/ai-llms-editor.scss
index 9397c2d40..49ce51ff6 100644
--- a/assets/stylesheets/modules/llms/common/ai-llms-editor.scss
+++ b/assets/stylesheets/modules/llms/common/ai-llms-editor.scss
@@ -6,8 +6,9 @@
     margin: 0 0 1em 0;
   }
 
-  &__configured + &__templates {
-    margin-top: 3em;
+  &__configured,
+  &__templates {
+    margin-top: 2em;
   }
 }
 
@@ -66,12 +67,41 @@
   }
 }
 
+.ai-llms-list-editor__configured,
+.ai-llms-list-editor__templates {
+  h2 {
+    font-size: var(--font-up-1);
+  }
+}
+
 .ai-llms-list-editor__configured {
   .d-toggle-switch {
     justify-content: center;
   }
 }
 
+.ai-tool-list-editor__current,
+.ai-persona-list-editor__current,
+.ai-llms-list-editor__configured {
+  .d-admin-table {
+    tr:hover {
+      background: inherit;
+    }
+    th,
+    td {
+      &:first-child {
+        padding-left: 0;
+      }
+    }
+    th,
+    td {
+      &:last-child {
+        padding-right: 0;
+      }
+    }
+  }
+}
+
 .ai-llms-list-editor__templates {
   &-list {
     display: grid;