Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Update linting #136

Merged
merged 1 commit into from
Nov 20, 2024
Merged

DEV: Update linting #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/components/activity-pub-authorize.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{{i18n "user.discourse_activity_pub.authorize.description"}}
</label>
<div class="activity-pub-authorize-controls">
{{#if verifiedDomain}}
{{#if this.verifiedDomain}}
<span class="activity-pub-authorize-verified-domain">
<a class="btn">{{this.domain}}</a>
<DButton
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/components/activity-pub-follow-domain.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
id="activity_pub_follow_domain_button"
/>
</div>
<div class={{footerClass}}>
<div class={{this.footerClass}}>
{{#if this.error}}
{{this.error}}
{{else if this.verifying}}
Expand Down
10 changes: 5 additions & 5 deletions assets/javascripts/discourse/components/activity-pub-status.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ export default class ActivityPubStatus extends Component {
}
}

willDestroy() {
super.willDestroy(...arguments);
this.messageBus.unsubscribe("/activity-pub", this.handleMessage);
}

findActor() {
const category = this.forComposer
? this.args.model.category
Expand All @@ -56,11 +61,6 @@ export default class ActivityPubStatus extends Component {
return actor;
}

willDestroy() {
super.willDestroy(...arguments);
this.messageBus.unsubscribe("/activity-pub", this.handleMessage);
}

@bind
handleMessage(data) {
const model = data.model;
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/components/modal/activity-pub-actor-follow.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
id="activity_pub_actor_follow_find_button"
/>
</div>
<div class={{footerClass}}>
<div class={{this.footerClass}}>
{{#if this.error}}
{{this.error}}
{{else if this.validating}}
Expand Down
6 changes: 3 additions & 3 deletions assets/javascripts/discourse/components/modal/activity-pub-post-info.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
<span class="activity-pub-state">{{d-icon
this.stateIcon
}}{{this.stateText}}</span>
{{#if showVisibility}}
{{#if this.showVisibility}}
<span class="activity-pub-visibility">{{d-icon
this.visibilityIcon
}}{{this.visibilityText}}</span>
{{/if}}
{{#if showUrl}}
{{#if this.showUrl}}
<span class="activity-pub-url">
<a
href={{@model.post.activity_pub_url}}
Expand All @@ -25,7 +25,7 @@
</a>
</span>
{{/if}}
{{#if showObjectId}}
{{#if this.showObjectId}}
<span class="activity-pub-object-id">
{{d-icon "link"}}
<span>{{@model.post.activity_pub_object_id}}</span>
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/templates/activity-pub-actor-followers.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
class="directory-table__cell activity-pub-follow-table-actions"
>
<ActivityPubFollowBtn
@actor={{actor}}
@actor={{this.actor}}
@follower={{follower}}
@reject={{route-action "reject"}}
@type="actor_reject"
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/templates/admin-plugins-activity-pub-actor-show.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class={{this.containerClass}}>
<div class="admin-title activity-pub-actor-title">
<h2>{{titleLabel}}</h2>
<h2>{{this.titleLabel}}</h2>
</div>

<div class="activity-pub-actor-header">
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/templates/admin-plugins-activity-pub-actor.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="admin-title activity-pub-actor-title">
<h2>{{title}}</h2>
<h2>{{this.title}}</h2>
</div>

<LoadMore
Expand Down
4 changes: 2 additions & 2 deletions assets/javascripts/discourse/templates/preferences/activity-pub.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

<ActivityPubAuthorize />

{{#if hasAuthorizations}}
{{#if this.hasAuthorizations}}
<div class="activity-pub-authorizations">
<h4>{{i18n "user.discourse_activity_pub.authorizations.title"}}</h4>
<label>{{i18n
"user.discourse_activity_pub.authorizations.description"
}}</label>
<ul>
{{#each authorizations as |authorization|}}
{{#each this.authorizations as |authorization|}}
<li>
<ActivityPubAuthorization
@authorization={{authorization}}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"devDependencies": {
"@discourse/lint-configs": "2.0.1",
"@discourse/lint-configs": "2.2.0",
"ember-template-lint": "6.0.0",
"eslint": "9.14.0",
"prettier": "2.8.8"
Expand Down
Loading