Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Don’t replace Rails logger in specs #132

Merged
merged 1 commit into from
Nov 13, 2024
Merged

DEV: Don’t replace Rails logger in specs #132

merged 1 commit into from
Nov 13, 2024

Conversation

Flink
Copy link
Contributor

@Flink Flink commented Nov 12, 2024

Instead of replacing the Rails logger in specs, we can instead use broadcast_to which has been introduced in Rails 7.

@Flink
DEV: Don’t replace Rails logger in specs
928ca44 
Instead of replacing the Rails logger in specs, we can instead use
broadcast_to which has been introduced in Rails 7.
@Flink Flink self-assigned this Nov 12, 2024
pmusaraj
pmusaraj approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@pmusaraj pmusaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@Flink Flink merged commit 016a5aa into main Nov 13, 2024
5 checks passed
@Flink Flink deleted the loic-use-broadcast-to branch November 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmusaraj pmusaraj pmusaraj approved these changes

Assignees

@Flink Flink

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flink @pmusaraj