Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Adding tags in admin UI #116

Merged
merged 3 commits into from
Sep 9, 2024
Merged

FIX: Adding tags in admin UI #116

merged 3 commits into from
Sep 9, 2024

Conversation

pmusaraj
Copy link
Contributor

@pmusaraj pmusaraj commented Sep 9, 2024

This was broken after an upgrade in core that refactored the TagDrop component. This PR switches to using the TagChooser component, since it requires no overrides.

This was broken after an upgrade in core that refactored the TagDrop
component. This PR switches to using the TagChooser component, since it
requires no overrides.
Copy link
Member

@keegangeorge keegangeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small suggestion before merging

assets/javascripts/discourse/models/activity-pub-actor.js Outdated Show resolved Hide resolved
@pmusaraj pmusaraj merged commit 8f327ee into main Sep 9, 2024
4 checks passed
@pmusaraj pmusaraj deleted the fix-tags-issue branch September 9, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants