DEV: Add system tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why does this commit do? This commit improves the test coverage for the theme by adding system tests which covers the basic functionality of the theme.
tgxworld
commented
Oct 20, 2023
| const dataName = dasherize(text); | ||
| const childLinks = this.linkArray.filter( | ||
| (link) => link.parent === parentFor | ||
| ); | ||
|
|
||
| return { | ||
| text, | ||
| title, |
There was a problem hiding this comment.
Caught a bug here while working on the system test.
| end | ||
| end | ||
|
|
||
| it "should not display the footer to anon users when `Show_footer_on_login_required_page` is false" do |
There was a problem hiding this comment.
I guess it's already a legacy thing but it's so weird the theme setting is capitalized 😬
There was a problem hiding this comment.
Yup this is something we will fix soon when we have the ability to migrate theme settings.
| let!(:theme) { upload_theme_component } | ||
|
|
||
| it "should display the footer" do | ||
| theme.update_setting(:Link_sections, "Section 1, Section 1 title|Section 2, Section 2 title") |
There was a problem hiding this comment.
Oh maybe the capitalization is a theme setting thing generally? Seems strange to me, but not related to this PR
martin-brennan
approved these changes
Oct 24, 2023
|
@martin-brennan Thank you for the review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this commit do?
This commit improves the test coverage for the theme by adding system tests which covers the basic functionality of the theme.