FIX: Footer not shown when show_footer_on_login_required_page is tr…

…ue (#43) This is fixes a regression introduced in a766346
discourse · Apr 8, 2024 · 12ff98a · 12ff98a
1 parent a677b33
commit 12ff98a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/javascripts/discourse/connectors/below-login/show-footer.hbs b/javascripts/discourse/connectors/below-login/show-footer.hbs
@@ -1,3 +1,3 @@
-{{#if (not (theme-setting "Show_footer_on_login_required_page"))}}
+{{#if (not (theme-setting "show_footer_on_login_required_page"))}}
   {{hide-application-footer}}
 {{/if}}
diff --git a/spec/system/footer_spec.rb b/spec/system/footer_spec.rb
@@ -74,7 +74,18 @@
     end
   end
 
-  it "should not display the footer to anon users when `Show_footer_on_login_required_page` is false" do
+  it "should display the footer to anon users when `show_footer_on_login_required_page` is true" do
+    SiteSetting.login_required = true
+
+    theme.update_setting(:show_footer_on_login_required_page, true)
+    theme.save!
+
+    visit("/")
+
+    expect(page).to have_css(".below-footer-outlet.custom-footer")
+  end
+
+  it "should not display the footer to anon users when `show_footer_on_login_required_page` is false" do
     SiteSetting.login_required = true
 
     theme.update_setting(:show_footer_on_login_required_page, false)