DEV: add ruby linting steps to linting job in theme workflow #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-brennan
approved these changes
Oct 16, 2024
|
Will leave this in place till all themes are updated by the update-rb-linting script so their CI won't fail. |
|
@tyb-talks this workflow needs to remain functional for third-party themes which don't have Ruby linting config. So maybe we should gate these new steps on the presence of the relevant config files? e.g. the stree config, and the rubocop config? |
tyb-talks
commented
Oct 17, 2024
| - name: Rubocop | ||
| if: ${{ !cancelled() }} | ||
| run: | | ||
| if test -f .rubocop.yml; then |
There was a problem hiding this comment.
I think we could use hashFiles in the if check above (it should return empty string when there aren't matching files) instead of this, but this follows how we've set out these checks elsewhere. @davidtaylorhq
davidtaylorhq
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds steps to lint ruby files in the theme workflow. Dependent on discourse/DiscoTOC#97.