Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove loading='lazy' attribute from multiple image components #114

Merged
merged 1 commit into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/app/(blogs)/blogs/[id]/components/Header.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export default function Header({ data }) {
width={512}
height={512}
className='size-full max-h-[440px] rounded-lg bg-tertiary object-cover'
loading='lazy'
/>
</>
);
Expand Down
2 changes: 0 additions & 2 deletions client/app/(bots)/bots/[id]/components/Tabs/Reviews.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ export default function Reviews({ bot }) {
width={48}
height={48}
className='size-[48px] rounded-2xl'
loading='lazy'
/>
) : (
<Image
Expand All @@ -157,7 +156,6 @@ export default function Reviews({ bot }) {
width={48}
height={48}
className='size-[48px] rounded-2xl'
loading='lazy'
/>
)}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ export default function ExtraOwners({ botId, canEditExtraOwners }) {
width={32}
height={32}
className='rounded-full'
loading='lazy'
/>

<span className='font-medium text-secondary'>
Expand Down
2 changes: 0 additions & 2 deletions client/app/(dashboard)/components/Table/ColumnRenderer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ export default function ColumnRenderer({ data }) {
height={32}
alt={`Emoji ${data.id}`}
className='pointer-events-none size-[32px] object-contain'
loading='lazy'
/>

<span className='font-medium'>
Expand All @@ -92,7 +91,6 @@ export default function ColumnRenderer({ data }) {
width={32}
height={32}
className='pointer-events-none size-[32px] object-contain'
loading='lazy'
/>
))}
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export default function EmojiPackageCard({ overridedImages, id, name, categories
className='size-full max-h-[48px] max-w-[48px] rounded-xl bg-secondary object-contain transition-all ease-in-out group-hover:bg-tertiary'
width={64}
height={64}
loading='lazy'
/>
))}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ export default function PackagePreview({ image_urls, setImageURLs, setIsPackage,
height={64}
alt={''}
className='size-[46px] object-contain sm:size-[64px]'
loading='lazy'
/>
</motion.div>
))}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export default function MockReviewCard({ username, content, rating }) {
width={32}
height={32}
className='size-[24px] rounded-full mobile:size-[32px]'
loading='lazy'
/>

<h3 className='truncate text-sm font-medium mobile:text-base'>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export default function Social({ data }) {
width={20}
height={20}
alt={`${social.type} Icon`}
loading='lazy'
/>

<span className='w-full truncate'>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ export default function Socials({ profile }) {
width={20}
height={20}
alt={`${social.type} Icon`}
loading='lazy'
/>

<span className='w-full truncate'>
Expand Down Expand Up @@ -237,7 +236,6 @@ export default function Socials({ profile }) {
width={20}
height={20}
alt={`${newSocialType} Icon`}
loading='lazy'
/>
)}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ export default function Reviews({ server }) {
width={48}
height={48}
className='size-[48px] rounded-2xl'
loading='lazy'
/>
) : (
<Image
Expand All @@ -157,7 +156,6 @@ export default function Reviews({ server }) {
width={48}
height={48}
className='size-[48px] rounded-2xl'
loading='lazy'
/>
)}

Expand Down
2 changes: 0 additions & 2 deletions client/app/components/Footer/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ export default function Footer() {
height={200}
className='size-[48px]'
alt='discord.place Logo'
loading='lazy'
/>

<h2 className='max-w-[350px] text-2xl font-bold text-primary'>
Expand Down Expand Up @@ -232,7 +231,6 @@ export default function Footer() {
width={100}
height={25}
alt='nodesty.com Logo'
loading='lazy'
/>
</Link>
</div>
Expand Down
1 change: 0 additions & 1 deletion client/app/components/Header/CollapsedHeader.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ export default function CollapsedHeader({ pathname }) {
height={64}
className='size-[48px]'
alt='discord.place Logo'
loading='lazy'
/>
</Link>
</div>
Expand Down
1 change: 0 additions & 1 deletion client/app/components/Logo/WithText.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ export default function WithText({ className }) {
height={64}
alt='discord.place Logo'
className='size-[32px]'
loading='lazy'
/>

<div
Expand Down
Loading