feat: Add no-install option
#9604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaw0r3k
requested review from
monbrey,
vladfrangu,
iCrawl,
almostSouji,
Jiralite and
suneettipirneni
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
jaw0r3k
commented
May 28, 2023
packages/create-discord-bot/template/TypeScript/src/events/index.ts
Outdated
Show resolved
Hide resolved
vladfrangu
reviewed
Jun 9, 2023
packages/create-discord-bot/template/TypeScript/src/events/index.ts
Outdated
Show resolved
Hide resolved
vladfrangu
approved these changes
Jun 9, 2023
sdanialraza
approved these changes
Jul 15, 2023
|
Please resolve conflicts. |
Jiralite
reviewed
Aug 9, 2023
packages/create-discord-bot/template/TypeScript/src/events/ready.ts
Outdated
Show resolved
Hide resolved
Jiralite
changed the title
no-install option and minor fixesno-install option and minor fixes
SpaceEEC
approved these changes
Aug 25, 2023
Jiralite
requested changes
Aug 25, 2023
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-guide-git-fork-jaw0r3k-create-bot-fixes-discordjs.vercel.app/guide/home/introduction |
|
Running Lighthouse audit... |
jaw0r3k
force-pushed
the
create-bot-fixes
branch
from
0da05e2
to
0434cc4
Compare
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
jaw0r3k
force-pushed
the
create-bot-fixes
branch
from
0434cc4
to
2ced651
Compare
Jiralite
changed the title
no-install option and minor fixesno-install option
Jiralite
approved these changes
Aug 26, 2023
almeidx
pushed a commit
to almeidx/discord.js
that referenced
this pull request
Sep 24, 2023
* chore: no install option + fix type * chore: apply suggestions Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> --------- Co-authored-by: Jaw0r3k <jaw0r3k.git@gmail.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Whilst it is better to install packages automatically, we can provide an option for the user to disable it. Also modifies
--packageManagerto--package-manager.Status and versioning classification: