Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support default_thread_rate_limit_per_user in channel creation #9339

Merged
merged 7 commits into from
Sep 20, 2023
Merged

feat: support default_thread_rate_limit_per_user in channel creation #9339

merged 7 commits into from
Sep 20, 2023

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Apr 7, 2023 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Adds:

Summary

🧵🐌🛠️

This pull request adds support for setting a default slowmode for threads in guild channels. It introduces a new property defaultThreadRateLimitPerUser to the GuildChannelManager, BaseGuildTextChannel, and CategoryChannel classes, and updates the channel creation methods and documentation accordingly.

Walkthrough
  • Add defaultThreadRateLimitPerUser property to guild channel classes and options (link, link, link, link)

Status and versioning classification:

  • Code changes have been tested against the Discord API
  • I know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Apr 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 2:59pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 2:59pm

@vercel
Copy link

vercel bot commented Apr 7, 2023

@jaw0r3k is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

SpaceEEC
SpaceEEC previously requested changes Apr 15, 2023
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

What's with the raw data types however? I feel like they don't belong into this PR 👀

@Jiralite Jiralite added this to the discord.js 13.17 milestone Apr 15, 2023
@jaw0r3k
Copy link
Contributor Author

jaw0r3k commented Apr 15, 2023 •
edited
Loading

Looking good.

What's with the raw data types however? I feel like they don't belong into this PR 👀

There were no other way to add it to this pr
Also even forum channel wasn't there

@SpaceEEC
Copy link
Member

I don't understand why these changes were made, your changes in index.d.ts do not refer to any of those.

@jaw0r3k
Copy link
Contributor Author

jaw0r3k commented Apr 16, 2023 •
edited
Loading

I don't understand why these changes were made, your changes in index.d.ts do not refer to any of those.

Oh yeah other channel types didn't have to be updated, but they weren't so idk
I could make another pr

vladfrangu
vladfrangu previously requested changes Apr 19, 2023
View reviewed changes
typings/rawDataTypes.d.ts Outdated Show resolved Hide resolved
@Jiralite
Copy link
Member

Jiralite commented May 7, 2023

This needs a rebase.

@jaw0r3k jaw0r3k force-pushed the v13-default_thread_rate_limit_per_user branch from 1217ab0 to 3015f0a Compare May 7, 2023 15:32
@jaw0r3k jaw0r3k force-pushed the v13-default_thread_rate_limit_per_user branch from 3015f0a to 883edb5 Compare May 7, 2023 15:34
@Jiralite Jiralite removed the blocked label Sep 19, 2023
@Jiralite Jiralite dismissed stale reviews from vladfrangu and SpaceEEC September 19, 2023 18:21

Stale.

@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 90
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-fork-jaw0r3k-v13-defaultthreadr-806a6c-discordjs.vercel.app/

@kodiakhq kodiakhq bot merged commit 759c0b0 into discordjs:v13 Sep 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@kyranet kyranet Awaiting requested review from kyranet

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
api support backport packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 13.17
Development

Successfully merging this pull request may close these issues.
5 participants
@jaw0r3k @SpaceEEC @Jiralite @vladfrangu @kyranet