Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NewsChannel)!: rename NewsChannel to AnnouncementChannel #10532

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor(NewsChannel)!: rename NewsChannel to AnnouncementChannel #10532

wants to merge 4 commits into from

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Oct 3, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Renames NewsChannel to AnnouncementChannel to be more in line with API naming (As it was renamed).

Related to:-

I imagine this would be a breaking change

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@imnaiyar imnaiyar requested a review from a team as a code owner October 3, 2024 17:24
@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 2:13pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 4, 2024 2:13pm

@imnaiyar imnaiyar changed the title refactor(NewsChannel): rename NewsChannel to AnnouncementChannel refactor(NewsChannel)!: rename NewsChannel to AnnouncementChannel Oct 3, 2024
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/core

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
packages:discord.js refactor semver:major
Projects
discord.js
Status: Todo
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@imnaiyar @Jiralite