fix(BaseInteraction): add missing props #10517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
I know I reported for specifically AutocompleteInteraction because that's the type affecting our bot, but this implementation may need to be moved up to BaseInteraction if all interactions are supposed to have these fields. |
Jiralite
approved these changes
Sep 22, 2024
Good point - I had thought it would only apply to "installed" commands, but it does seem to be on all of them. I'll move it. |
monbrey
changed the title
TAEMBO
reviewed
Sep 23, 2024
sdanialraza
reviewed
Sep 23, 2024
vladfrangu
approved these changes
Sep 23, 2024
Co-authored-by: Danial Raza <danialrazafb@gmail.com>
didinele
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10516
Status and versioning classification: