fix(website): nullable parameters on events #10510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Qjuh
force-pushed
the
website/nullable-event-params
branch
from
820f479
to
a54349d
Compare
iCrawl
approved these changes
Sep 15, 2024
almeidx
approved these changes
Sep 15, 2024
Jiralite
approved these changes
Sep 15, 2024
monbrey
pushed a commit
to monbrey/discord.js
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds
| nullto the types on website for parameter of events that are nullable. This was a regression ever since js events were parsed into api-extractor generated docs.See https://discord.js.org/docs/packages/discord.js/main/Client:Class#presenceUpdate for an example, oldPresence here is nullable but not shown as such. This PR fixes that.
Status and versioning classification: