Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ApplicationEmoji to EmojiResolvable and MessageReaction#emoji #10477

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

Moebits
Copy link
Contributor

@Moebits Moebits commented Sep 3, 2024

Please describe the changes this PR makes and why it should be merged:

When using typescript you can't react to a message with an ApplicationEmoji because EmojiResolvable lacks the type.

Edit: I also updated BaseGuildEmojiManager.js and added ApplicationEmoji to the MessageReaction#emoji getter.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Moebits Moebits requested a review from a team as a code owner September 3, 2024 05:22
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 0:31am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 0:31am

@Moebits Moebits changed the title types: Add ApplicationEmoji to EmojiResolvable and MessageReaction#emoji types: Add ApplicationEmoji to EmojiResolvable Sep 3, 2024
@imnaiyar
Copy link
Contributor

imnaiyar commented Sep 3, 2024

This may also need updating

/**
* Data that can be resolved into a GuildEmoji object. This can be:
* * A Snowflake
* * A GuildEmoji object
* * A ReactionEmoji object
* @typedef {Snowflake|GuildEmoji|ReactionEmoji} EmojiResolvable

@Moebits
Copy link
Contributor Author

Moebits commented Sep 3, 2024

Thanks I updated BaseGuildEmojiManager.js and it seemed to fix the equality comparison with MessageReaction#emoji as well.

@Moebits Moebits changed the title types: Add ApplicationEmoji to EmojiResolvable feat: Add ApplicationEmoji to EmojiResolvable and MessageReaction#emoji Sep 4, 2024
@kodiakhq kodiakhq bot merged commit c633d5c into discordjs:main Oct 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants