Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): show name of inheriting class on search index #10424

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Aug 2, 2024

Please describe the changes this PR makes and why it should be merged:

With #10415 the name on search index includes the name of the class now, but for inherited properties it's the name of the defining class instead of the one the entry links to.

This PR fixes this and also changes the delimiter so the name for https://discord.js.org/docs/packages/discord.js/14.15.3/ClientUser:Class#bot would be ClientUser#bot instead of User.botnow.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Qjuh Qjuh requested a review from a team as a code owner August 2, 2024 16:20
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2024 0:57am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 3, 2024 0:57am

@Qjuh Qjuh requested a review from ckohen August 3, 2024 13:40
@kodiakhq kodiakhq bot merged commit f623e7a into discordjs:main Aug 3, 2024
24 checks passed
@Qjuh Qjuh deleted the fix/scripts-scoped-name branch September 14, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants