Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove "typings", "wip", and "workflow" scope #10340

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jun 8, 2024

Please describe the changes this PR makes and why it should be merged:

  • "types" is the preferred scope to use over "typings". This has been kept in cliff.toml files (for changelogs) as some prior commits used this scope
  • "ci" is the preferred scope over "workflow"
  • "wip" was not allowed in the first place

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@Jiralite Jiralite requested a review from iCrawl as a code owner June 8, 2024 20:41
@Jiralite Jiralite added the chore label Jun 8, 2024
Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 6:37pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 6:37pm

@Jiralite Jiralite changed the title chore: Remove "typings" commit lint chore: Remove "typings" and "workflow" from commitlintrc.json Jun 8, 2024
@Jiralite Jiralite changed the title chore: Remove "typings" and "workflow" from commitlintrc.json chore: Remove "typings", "wip", and "workflow" from commitlintrc.json Jun 8, 2024
@Jiralite Jiralite changed the title chore: Remove "typings", "wip", and "workflow" from commitlintrc.json chore: Remove "typings", "wip", and "workflow" scope Jun 8, 2024
@Jiralite Jiralite force-pushed the chore/remove-typings-commit-lint branch from 76bab4c to 7d1071d Compare June 18, 2024 18:35
@kodiakhq kodiakhq bot merged commit ba0cb66 into main Jun 18, 2024
25 checks passed
@kodiakhq kodiakhq bot deleted the chore/remove-typings-commit-lint branch June 18, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants