Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageManager): poll methods don't need a channel id #10249

Merged
merged 2 commits into from
May 4, 2024

Conversation

didinele
Copy link
Member

@didinele didinele commented May 4, 2024

average discord.js release (blundered)

@didinele didinele requested a review from a team as a code owner May 4, 2024 18:59
Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 7:03pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 4, 2024 7:03pm

Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing type updates
  • fetchPollAnswerVoters needs to be updated too
  • both of these methods are being used in the Poll and PollAnswer classes

@Jiralite Jiralite added this to the discord.js 14.15.1 milestone May 4, 2024
@didinele didinele changed the title fix(MessageManager): end poll does not need channel id fix(MessageManager): poll methods don't need a channel id May 4, 2024
@didinele didinele requested a review from almeidx May 4, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants