perf(Presence): prefer boolean client status comparison before activity checks #10213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JMTK
changed the title
JMTK
changed the title
vladfrangu
approved these changes
Apr 14, 2024
kyranet
approved these changes
Apr 14, 2024
Jiralite
approved these changes
Apr 20, 2024
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Prefer boolean client status comparison before activity checks. This vastly helps performance in scenarios where the only presence change is a client status change, such as going from mobile to desktop. While this change seems very trivial, presences are by-far the highest ingress event for the websockets so this can have pretty beneficial performance impact if we're able to take advantage of it
I pulled out a presence that had more than 3 activities as a base. In all screenshots, the bottom is the current code, top is the new code. Here are my findings:
Scenario 1
Old/New presences have no difference between them. Pretty much equal performance
Scenario 2
This was the ideal scenario that I was making this PR for. The only difference between the presences is the client status is "desktop" instead of "mobile". In this case we were able to short-circuit the activity comparisons.
Scenario 3
The only difference between the presences is in the activities, client status is the same.
On my personal Discord bot, I receive ~39000 presence updates in a 5 minute span. If I'm able to shave off 2 function calls from the stack on even 1/100 of those, that would remove 780 function calls. I think it would be worth it.
Status and versioning classification:
Patch