Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): cmdk duplicate values #10100

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

brynpttrsn
Copy link
Contributor

@brynpttrsn brynpttrsn commented Jan 25, 2024

Please describe the changes this PR makes and why it should be merged:

Resolves duplicate results in cmdk dialog from being highlighted/selected on hover or with arrow navigation.

F9B2FE6C-332A-423F-8D08-AC9CB0F6F2BB

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Jan 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 9:42pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 3, 2024 9:42pm

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a0c83a2) 58.55% compared to head (fed923a) 58.53%.
Report is 5 commits behind head on main.

Files Patch % Lines
apps/website/src/components/CmdK.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10100      +/-   ##
==========================================
- Coverage   58.55%   58.53%   -0.03%     
==========================================
  Files         244      244              
  Lines       17281    17267      -14     
  Branches     1248     1244       -4     
==========================================
- Hits        10119    10107      -12     
+ Misses       7117     7115       -2     
  Partials       45       45              
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kodiakhq kodiakhq bot merged commit f691658 into discordjs:main Feb 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants