Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): search hanging on complex types #10095

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Jan 21, 2024

Please describe the changes this PR makes and why it should be merged:

cmdk package builds the list based on value, which gets inferred from the content if not explicitly set. This caused the render to majorly lag for things with long descriptions because it was using a recursive function to build information for the value from command-score on that long string.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner January 21, 2024 15:26
Copy link

vercel bot commented Jan 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 3:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 21, 2024 3:28pm

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7e12bee) 58.51% compared to head (f3297e6) 58.49%.
Report is 1 commits behind head on main.

Files Patch % Lines
apps/website/src/components/CmdK.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10095      +/-   ##
==========================================
- Coverage   58.51%   58.49%   -0.03%     
==========================================
  Files         242      242              
  Lines       17248    17255       +7     
  Branches     1246     1246              
==========================================
  Hits        10093    10093              
- Misses       7110     7117       +7     
  Partials       45       45              
Flag Coverage Δ
website 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almeidx almeidx linked an issue Jan 21, 2024 that may be closed by this pull request
@kodiakhq kodiakhq bot merged commit 1431c18 into discordjs:main Jan 21, 2024
22 checks passed
@Qjuh Qjuh deleted the fix/search-lag branch January 21, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Search freezes the page
4 participants