Add support for components V2 #2809
Open
+9,335
−1,223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove generic from the ComponentReplacer parameter; I don't think it's possible to get the correct type - Refactor the replacing logic, move to IReplacerAware
Also add mutators, add to JSON
- Removed generics - Logic now applies the replacer regardless of type As the replacer receives a Component, it's their job to check, though facilitated by provided factories - Avoid recursing into new components by checking reference equality
All components have a numeric ID, it used to be that text inputs didn't, but this was a bug
Instead of when building the message This prevents duplication of files when copying a message from another
I am never touching this ever again
Discord-generated IDs start at 1, sending 0 increments it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This adds the new component system (aka Components V2).
[Waiting on API docs]
This is not released yet, you will not be able to send messages using components V2, however you can include the snapshot to see what code changes will be required and what the usages with future components will be. If you do try it out, make sure to give your opinion on the JDA dev thread
Note: While there are tests, the OpenRewrite recipe has not been tested on an actual project yet
Supersedes #2806.