Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Grammar fixes #208

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Grammar fixes #208

wants to merge 1 commit into from

Conversation

viktordimov
Copy link

Fixed grammar issues and standarised to EU Spanish.

Copy link
Contributor

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't believe that as an Andalusian with native Spanish, I wrote so many typos. Welp, I guess I made this a very long ago and tired 😂

Some requested changes, there were typos!

MONITOR_COMMAND_HANDLER_ABORTED: 'Abortado.',
INHIBITOR_COOLDOWN: (remaining) => `El comando se está enfriando. Quedan ${remaining} segundos.`,
INHIBITOR_DISABLED: 'Este comando está desactivado.',
INHIBITOR_MISSING_BOT_PERMS: (missing) => `Permisos insuficientes, necesitas: **${missing}**`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was correct, the missing permissions is for the bot, not for the user.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INHIBITOR_MISSING_BOT_PERMS Didn't read that... 😄

COMMANDMESSAGE_MISSING_REQUIRED: (name) => `${name} es un argumento requerido.`,
COMMANDMESSAGE_MISSING_OPTIONALS: (possibles) => `Falta una opción requerida: (${possibles})`,
COMMANDMESSAGE_NOMATCH: (possibles) => `Su opción no coincide con ninguna de las posibilidades: (${possibles})`,
MONITOR_COMMAND_HANDLER_REPROMPT: (tag, error, time) => `${tag} | **${error}** | Tienes **${time}** segundos para responder a este mensage emergente con un argumento válido. Escribe **"ABORT"** para abortar el proceso.`, // eslint-disable-line max-len
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one had "Usted tiene" for formality, "Tienes" sounds very direct, but I'm open to reword this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, is it supposed to sound formal? I wasn't aware, sorry.

Copy link
Author

@viktordimov viktordimov Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
MONITOR_COMMAND_HANDLER_REPROMPT: (tag, error, time) => `${tag} | **${error}** | Tienes **${time}** segundos para responder a este mensage emergente con un argumento válido. Escribe **"ABORT"** para abortar el proceso.`, // eslint-disable-line max-len
MONITOR_COMMAND_HANDLER_REPROMPT: (tag, error, time) => `${tag} | **${error}** | Tiene **${time}** segundos para responder a este mensaje emergente con un argumento válido. Escriba **"ABORT"** para abortar el proceso.`, // eslint-disable-line max-len

I think I saw another "mensage" somewhere, probably near the same line.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 6 mensage's in total.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, is it supposed to sound formal? I wasn't aware, sorry.

It's a matter of preference, doesn't really matter.

There are 6 mensage's in total.

Should be changed to mensaje.

INHIBITOR_MISSING_BOT_PERMS: (missing) => `Permisos insuficientes, necesitas: **${missing}**`,
INHIBITOR_NSFW: 'No puedes usar comandos NSFW en este canal.',
INHIBITOR_PERMISSIONS: 'No tienes permiso para usar este comando.',
INHIBITOR_REQUIRED_CONFIGS: (settings) => `El servidor no tiene las siguientes claves ${settings.length > 1 ? 's' : ''}: **${settings.join(', ')}** y no puedo realizar esa acción.`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following ternary gives it the s when it's in plural, but I just noticed there was a little bug here, 0 is also plural, so it should do "clave" when 1, and "claves" otherwise.

Suggested change
INHIBITOR_REQUIRED_CONFIGS: (settings) => `El servidor no tiene las siguientes claves ${settings.length > 1 ? 's' : ''}: **${settings.join(', ')}** y no puedo realizar esa acción.`,
INHIBITOR_REQUIRED_CONFIGS: (settings) => `El servidor no tiene las siguientes clave${settings.length === 1 ? '' : 's'}: **${settings.join(', ')}** y no puedo realizar esa acción.`,

util.codeBlock('', [
'El enlace de arriba está generado con los permisos necesarios para ejecutar todos los comandos actuales.',
'Entiendo que no todos los permisos son necesarios para todos los servidores, pero puedes cambiarlos sin problema.',
'Si intentas usar un comando que requira más permisos de los que tengo, te lo haré saber.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'Si intentas usar un comando que requira más permisos de los que tengo, te lo haré saber.'
'Si intentas usar un comando que requiera más permisos de los que tengo, te lo haré saber.'

COMMAND_PING: '¿Ping?',
COMMAND_PING_DESCRIPTION: 'Ejecuta una prueba de conexión a Discord.',
COMMAND_PINGPONG: (diff, ping) => `¡Pong! (El viaje duró: ${diff}ms. Latencia: ${ping}ms.)`,
COMMAND_INVITE_SELFBOT: '¿Para qué quiere un enlace de invitación un selfbot?',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was removed in en-US or should be removed soon otherwise. We don't support selfbots so there's no point on supporting this line.

Suggested change
COMMAND_INVITE_SELFBOT: '¿Para qué quiere un enlace de invitación un selfbot?',

languages/es-ES.js Show resolved Hide resolved
'• 🗄 "Proveedores", los cuales te permiten conectar Klasa con una base de datos cualquiera.',
'• ✅ "Finalizadores", los cuales son ejecutados después de un comando lanzado con éxito.',
'• ➕ "Extensibles", código que actua pasivamente. Añaden propiedades o métodos a las clases de Discord.js.',
'• 🌐 "Lenguajes", los cuales permiten usar diferentes lenguages en tu bot.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A typo for a typo! Fixed this 😅

Suggested change
'• 🌐 "Lenguajes", los cuales permiten usar diferentes lenguages en tu bot.',
'• 🌐 "Lenguajes", los cuales permiten usar diferentes lenguajes en tu bot.',

@viktordimov
Copy link
Author

By the type of language that was originally used, I swear I thought you were an American or a native English speaker with decent Spanish and Google Translate
LOL

@kyranet
Copy link
Contributor

kyranet commented Jun 21, 2019

Nah, it's just that in Andalusia we have an informal formality 😝

We can be really friendly, buds, even family, for a lot of people, but we keep our manners by saying "Usted" (which is formal Spanish) over "Tú" (informal, but also direct and what is usually taught at schools (until A grades, though).

Not sure which one Google Translator uses, I always panic when I GTranslate English to Spanish 🤣

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants