Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Update index.d.ts #352

Open
wants to merge 1 commit into
base: d.js_managers
Choose a base branch
from

Conversation

5factor
Copy link

@5factor 5factor commented Jun 24, 2020

Description of the PR

Fix types

Changes Proposed in this Pull Request (List new items in CHANGELOG.MD)

  • Replace DataStore with BaseManager
  • Remove "export { DashboardClient as Client }" (cannot export in a module augmentation)

Semver Classification

  • This PR only includes documentation or non-code changes.
  • This PR fixes a bug and does not change the (intended) framework interface.
  • This PR adds methods or properties to the framework interface.
  • This PR removes or renames methods or properties in the framework interface.

- Replace DataStore with BaseManager
- Remove "export { DashboardClient as Client }" (cannot export in a module augmentation)
Comment on lines -20 to -21
export { DashboardClient as Client };

Copy link

@favna favna Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove these lines. It's perfectly valid. Your IDE is just wrong there if it tells you it cannot support it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I receive this error in both Visual Studio Code and Webstorm.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants