Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to support domains with 3 characters or more #141

Open
jimthedj65 opened this issue Apr 29, 2024 · 0 comments
Open

Request to support domains with 3 characters or more #141

jimthedj65 opened this issue Apr 29, 2024 · 0 comments

Comments

@jimthedj65
Copy link

BNS currently only supports 8 character plus. It would be nice to have support for at least 4 character domain names. Going into any production this will be an issue that will come up time and again.

@tuhalf has modified /rpc/socks.go line 613 with

deviceID = modeHostPort[2]+domain[0 : len(domain)-len(suffix)-1]

which supports 7 character domain names, could this be added to the mainstream to support domains with 3 characters or more?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimthedj65