Feature - custom albums #123

beeradmoore · 2023-05-25T06:53:45Z

Description

Adds the ability to create albums when saving assets.

Related to issue

Fixes #122

API Changes

No breaking changes.
SaveAsync now has an additional argument albumName which is null by default.
If albumName is null then we continue doing what we do (iOS: No album, Android: Album created of the same name as the app).
If albumName is an empty string then no album will be created on both iOS and Android.
If albumName is anything else, then an album is created with that name on both iOS and Android.

Recommendations for testing

I didn't update the sample app as I wasn't sure how to express "keeping this blank will make an album on Android, no album on iOS". But the way I tested was by changing things in SaveVM.cs, from:

await MediaGallery.SaveAsync(type, stream, name);

to:

await MediaGallery.SaveAsync(type, stream, name, "My Album");

PR Checklist

All projects build
Has samples
Rebased onto current main

dimonovdd · 2023-06-01T13:39:14Z

Hi. I'm very busy right now, I'll watch it next week. Sorry

dimonovdd · 2023-06-01T13:42:21Z

MediaGallery/MediaGallery/SaveMedia.ios.cs

+                {
+                    Predicate = NSPredicate.FromFormat($"title=\"{albumName}\"")
+                };
+                collection = PHAssetCollection.FetchAssetCollections(PHAssetCollectionType.Album, PHAssetCollectionSubtype.AlbumRegular, fetchOptions).FirstObject as PHAssetCollection;


Should we request additional permissions? On which versions of iOS have you tested this?

As far as I am aware no additional permissions are required to make an album. Our production app has only had NSPhotoLibraryUsageDescription in it for about 7 years.

It was only until we moved to using Xamarin.MediaGallery did we even realise there was a new NSPhotoLibraryAddUsageDescription permission.

I have only been testing the new code on iOS 16.5, but the source where I originally wrote would have been at least iOS 10 and up.

If I specify the album name, it asks for additional permission. I don't really like this behavior. It will not be clear to users. Why should the user be able to select the photos to which he provides access when saving the photo?

2023-08-10.10.56.08.PM.mov

beeradmoore · 2023-06-02T00:25:10Z

Hi. I'm very busy right now, I'll watch it next week. Sorry

No worries. In the mean time I might also make a new branch (from main) and see if I can tidy up the structure and get multi targeting to work cleaner so its easier to test/build for going forwards.

I like that a lot of this library is now in MAUI Essentials, but it seems things work slow over there to get updated even when it is PR'd. Plus certain things they straight up said no to (seen your comments RE: saving to gallery and trying to get it in Xamarin.Essentails + MAUI)

dimonovdd · 2023-06-12T06:26:21Z

@beeradmoore Hi

can you update the sample? If filed is null or empty, we can use:

await MediaGallery.SaveAsync(type, stream, name);

beeradmoore · 2023-06-12T21:02:30Z

Do you want the a comment in the sample explaining what that property does or do you want me to hard code an album name in the sample so people know it's used?

dimonovdd · 2023-06-22T07:48:01Z

I want us to be able to change it in the sample app.

beeradmoore · 2023-07-13T06:45:57Z

Sorry for the delay on adding that. I was pulled onto other projects.

I think I have added how you wished. This is how it looks on iOS and Android.

Default Xamarin.Forms styling leaves a lot to be desired on Android 😅.

Regarding future changes (I can file a new issue to discuss rather than on this PR), would you have any objection to me tinkering with the project structure and see if we can get better XF/MAUI side by side support without having to nuke large portions of the project in order to get it to build?

dimonovdd · 2023-08-10T19:18:33Z

Sorry for the delay on adding that

@beeradmoore Please forgive me. I have a little health problems right now. And also my team is now migrating our project to MAUI. I don't have time at all. This is some kind of hell

would you have any objection to me tinkering with the project structure

I'll be only too glad

MediaGallery/MediaGallery/SaveMedia.ios.cs

dimonovdd · 2023-08-10T19:24:47Z

Can you boost the version numbers? Or build a nuget? Let's publish version 2.2.2-preview1 right from this Pull Request
And update README.md please

MediaGallery/MediaGallery/SaveMedia.ios.cs

beeradmoore · 2023-08-10T22:14:47Z

Hey @dimonovdd , no worries about the delay.

I'll be only too glad

Is there a preferred place you'd like me to make some proposals to changes, make a new issue, DM on Twitter, email?

This is some kind of hell

I can't wait to migrate my main app to MAUI 😅

I have added those changes you requested. Sorry about missing those .NET 6 things, I never built for .NET 6 so never picked that up. I am not sure of the process you use to build nuget packages so I can't test if the version changes to 2.2.2-preview1 is done how they are expected, nor could I test in a MAUI app.

Ironically part of changes I want to do is add some scripts to make it easier for people to build the packages (like the two small scripts I have here) :P

If you are free to leave some instructions for that below I can make sure it builds and then also test in the sample app on MAUI and Xamarin builds.

dimonovdd · 2023-08-13T17:30:44Z

@beeradmoore easiest way:

Open Xamarim.MediaGallery.sln
Delete Permission, Sample.Common, Sample, Sample.Android, Sample.iOS projects
Remove that line from MediaGallery project

<TargetFrameworks>netstandard2.0;Xamarin.iOS10;MonoAndroid10.0;MonoAndroid11.0;MonoAndroid12.0;MonoAndroid13.0;</TargetFrameworks>

Open Xamarim.MediaGallery.targets and set _UseNuget - false
Closes: # IDE
Clean bin, obj, .vs, .idea folders
Open Xamarim.MediaGallery.sln
Build Sample App

beeradmoore · 2023-08-17T00:57:02Z

Been fighting with it for a few days and I am getting weird errors like

msbuild.sdk.extras/3.0.44/Build/Workarounds.targets(5,5): Error: If you are building projects that require targets from full MSBuild or MSBuildFrameworkToolsPath, you need to use desktop msbuild ('msbuild.exe') instead of 'dotnet build' or 'dotnet msbuild' (Permission.Maui)

when I didn't change anything, and it randomly worked but the .nupkg it built appears to be net6.0 only, no legacy Xamarin support. Other times it gives me this error,

Microsoft.NET.TargetFrameworkInference.targets(127,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 6.0. Either target .NET Core 5.0 or lower, or use a version of the .NET SDK that supports .NET Core 6.0.

I was looking for packages that multi-target old and new Xamarin/net6 stuff to see how they accomplish it and I came across James Montemagnos StoreReviewPlugin. How his project is structured seems good, but I downloaded it and attempted to build it and got similar issues as above.

I am unsure if my system is able to build the correct resulting nugets, and while tidying up the csproj/targets system in this project was something I wanted to do (make it easier for new people to jump in and build and then contribute) I am going to need to sort out if my system is being funky here.

dimonovdd · 2023-08-24T19:12:44Z

when I didn't change anything, and it randomly worked but the .nupkg it built appears to be net6.0 only, no legacy Xamarin support. Other times it gives me this error,

haha, Microsoft..... Use windows + console

I was looking for packages that multi-target old and new Xamarin/net6 stuff to see how they accomplish it and I came across James Montemagnos StoreReviewPlugin. How his project is structured seems good, but I downloaded it and attempted to build it and got similar issues as above.

it is very painful

beeradmoore · 2023-08-24T20:51:42Z

I had some luck updating to using Xamarin.Legacy.Sdk for the csproj type.

But on the other hand I was wondering what it'd take to convince you to release 2.2.2-preview1 and then branch for history sake, and turn main branch into v3.X .NET 6 only branch so things can be tidied up that way 👀

EDIT:

Use windows + console

I didn't know I could. I assumed anything that touched iOS required me to use my macOS machine for Xcode support, but I guess net6-ios does not. I'll try again this weekend.

beeradmoore · 2023-08-27T23:40:25Z

Update: Trying to build on windows didn't work -_-

dimonovdd · 2023-10-06T08:38:21Z

and turn main branch into v3.X .NET 6 only branch so things can be tidied up that way

I won't do it. Now we are trying to remake our application on MAUI. Attempts are unsuccessful.

See: dotnet/maui#13564

dimonovdd · 2023-10-06T08:47:29Z

I think I can write build scripts to create nugget

dimonovdd · 2024-10-31T06:12:40Z

@beeradmoore
Hi, the project has become much easier. I think we can get back to that PR. But let's fix all the little things you wrote about first.

beeradmoore · 2024-10-31T06:14:52Z

Sounds good. I'll see if I can rebase this onto main from my end. If not I can remake it.

beeradmoore · 2024-10-31T06:22:23Z

@dimonovdd , I attempted a rebase but had some odd conflicts. More than happy to cancel this PR and I can re-make those changes from current main this weekend.

beeradmoore added 2 commits May 25, 2023 14:37

Updated .gitignore to ignore .DS_Store files

052338e

Updated MediaGallery SaveAsync to support albums.

a6f309c

dimonovdd reviewed Jun 1, 2023

View reviewed changes

Updated sample to include custom album

c25c220

dimonovdd reviewed Aug 10, 2023

View reviewed changes

MediaGallery/MediaGallery/SaveMedia.ios.cs Outdated Show resolved Hide resolved

dimonovdd requested changes Aug 10, 2023

View reviewed changes

MediaGallery/MediaGallery/SaveMedia.ios.cs Show resolved Hide resolved

MediaGallery/MediaGallery/SaveMedia.ios.cs Show resolved Hide resolved

beeradmoore added 3 commits August 11, 2023 07:39

Requested changes for PR

c2b0207

Added example into README for saving in a custom album

2757f55

Bumped build number to 2.2.2-preview1

5bd9e1e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature - custom albums #123

Feature - custom albums #123

beeradmoore commented May 25, 2023 •

edited by dimonovdd

Loading

dimonovdd commented Jun 1, 2023

dimonovdd Jun 1, 2023

beeradmoore Jun 2, 2023

dimonovdd Aug 10, 2023

beeradmoore commented Jun 2, 2023

dimonovdd commented Jun 12, 2023

beeradmoore commented Jun 12, 2023

dimonovdd commented Jun 22, 2023

beeradmoore commented Jul 13, 2023

dimonovdd commented Aug 10, 2023

dimonovdd commented Aug 10, 2023 •

edited

Loading

beeradmoore commented Aug 10, 2023 •

edited

Loading

dimonovdd commented Aug 13, 2023 •

edited

Loading

beeradmoore commented Aug 17, 2023

dimonovdd commented Aug 24, 2023

beeradmoore commented Aug 24, 2023 •

edited

Loading

beeradmoore commented Aug 27, 2023 •

edited

Loading

dimonovdd commented Oct 6, 2023

dimonovdd commented Oct 6, 2023

dimonovdd commented Oct 31, 2024

beeradmoore commented Oct 31, 2024

beeradmoore commented Oct 31, 2024

Feature - custom albums #123

Are you sure you want to change the base?

Feature - custom albums #123

Conversation

beeradmoore commented May 25, 2023 • edited by dimonovdd Loading

Description

Related to issue

API Changes

Recommendations for testing

PR Checklist

dimonovdd commented Jun 1, 2023

dimonovdd Jun 1, 2023

Choose a reason for hiding this comment

beeradmoore Jun 2, 2023

Choose a reason for hiding this comment

dimonovdd Aug 10, 2023

Choose a reason for hiding this comment

beeradmoore commented Jun 2, 2023

dimonovdd commented Jun 12, 2023

beeradmoore commented Jun 12, 2023

dimonovdd commented Jun 22, 2023

beeradmoore commented Jul 13, 2023

dimonovdd commented Aug 10, 2023

dimonovdd commented Aug 10, 2023 • edited Loading

beeradmoore commented Aug 10, 2023 • edited Loading

dimonovdd commented Aug 13, 2023 • edited Loading

beeradmoore commented Aug 17, 2023

dimonovdd commented Aug 24, 2023

beeradmoore commented Aug 24, 2023 • edited Loading

beeradmoore commented Aug 27, 2023 • edited Loading

dimonovdd commented Oct 6, 2023

dimonovdd commented Oct 6, 2023

dimonovdd commented Oct 31, 2024

beeradmoore commented Oct 31, 2024

beeradmoore commented Oct 31, 2024

beeradmoore commented May 25, 2023 •

edited by dimonovdd

Loading

dimonovdd commented Aug 10, 2023 •

edited

Loading

beeradmoore commented Aug 10, 2023 •

edited

Loading

dimonovdd commented Aug 13, 2023 •

edited

Loading

beeradmoore commented Aug 24, 2023 •

edited

Loading

beeradmoore commented Aug 27, 2023 •

edited

Loading