Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #646 #650

Merged
merged 1 commit into from
Dec 25, 2023
Merged

fix #646 #650

merged 1 commit into from
Dec 25, 2023

Conversation

shy1132
Copy link
Contributor

@shy1132 shy1132 commented Dec 25, 2023

tiny oversight, if it couldn't find a viable social context type it would still pass {} to appendTweet which caused it to read options.top.text and options.top.icon as undefined, so now it just sets options.top to null in such cases

@dimdenGD dimdenGD merged commit 7168e50 into dimdenGD:master Dec 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shy1132 @dimdenGD