Improved tweet click event handling. #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were some issues with tweet click event handling previously, so I fixed them. For user experience, this effectively means that: - Clicking on the text of the tweet (or other "deadzones") will now properly open that tweet. I added two helper functions for determining relationship to a parent. Additionally, I added two extra classes: - tweet-button, which denotes a button behaviour for clickable elements that should not open the tweet. This includes all of the buttons at the bottom of the tweet, as well as the translate button. - tweet-edit-section, for the reply and quote editors, which should also not be interactable.
|
instead of isChildOfClass and isChildOfTag you should probably use .closest |
|
Forgot that existed, honestly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some issues with tweet click event handling previously, so I fixed them. For user experience, this effectively means that:
I added two helper functions for determining relationship to a parent. Additionally, I added two extra classes:
tweet-button, which denotes a button behaviour for clickable elements that should not open the tweet. This includes all of the buttons at the bottom of the tweet, as well as the translate button.tweet-edit-section, for the reply and quote editors, which should also not be interactable.This solves issue #588.