semantic version

digma-ai · Nov 24, 2024 · 41e6b9c · 41e6b9c
1 parent 3b37ea8
commit 41e6b9c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/...a/otel/javaagent/extension/instrumentation/methods/DigmaMethodsInstrumentationModule.java b/...a/otel/javaagent/extension/instrumentation/methods/DigmaMethodsInstrumentationModule.java
@@ -17,6 +17,7 @@
 import static net.bytebuddy.matcher.ElementMatchers.not;
 
 // todo: method instrumentation is not used anymore. we use digma-agent to inject @WithSpan annotation to methods
+//  to enable it uncomment @AutoService and enable com.digma.otel.javaagent.extension.instrumentation.methods.MethodsInstrumentationTests
 //@AutoService(InstrumentationModule.class)
 public class DigmaMethodsInstrumentationModule extends InstrumentationModule {
 

diff --git a/...m/digma/otel/javaagent/extension/instrumentation/methods/MethodsInstrumentationTests.java b/...m/digma/otel/javaagent/extension/instrumentation/methods/MethodsInstrumentationTests.java
@@ -10,6 +10,7 @@
 import io.opentelemetry.sdk.common.InstrumentationScopeInfo;
 import org.assertj.core.api.Assertions;
 import org.digma.otel.extension.extension.version.BuildVersion;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
@@ -20,6 +21,9 @@
 import static io.opentelemetry.semconv.SemanticAttributes.CODE_FUNCTION;
 import static io.opentelemetry.semconv.SemanticAttributes.CODE_NAMESPACE;
 
+//we don't use method instrumentation anymore. see comment in
+//com.digma.otel.javaagent.extension.instrumentation.methods.DigmaMethodsInstrumentationModule
+@Disabled
 class MethodsInstrumentationTests {
 
     //Note: digma-junit instrumentation is disabled in jvm args. otherwise the