Restrict pattern for space-separated arguments in glob embed regex #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcarlsonberg
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
What issue does this relate to?
N/A
What should this PR do?
The previous implementation of the regex pattern used for the glob embed could result in too much recursion when evaluating a string that had a large number of spaces in the glob, followed by a test on a new line.
This PR restricts the regex pattern being used, so instead of looking for a space followed by any character, we're now looking for a space followed by any non-space character, avoiding the excessive recursion. A test has also been added to confirm that this regex no longer has this ReDoS issue.
What are the acceptance criteria?
All tests continue to pass, including the new one that would previously reproduce the ReDoS.