Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color palette to match new design system #83

Merged

Conversation

dbadea-heits
Copy link
Contributor

Type of Change

  • SCSS Styling:
  • Prism environment code blocks themes

What issue does this relate to?

Update color themes for code blocks

What should this PR do?

Updates color themes for code blocks

What are the acceptance criteria?

Color themes for the code blocks are updated to use new color scheme

@dbadea-heits dbadea-heits force-pushed the dbadea/code-block-styling branch 3 times, most recently from 687cc8f to 6741c63 Compare October 16, 2023 12:58
styles/_typography.scss Outdated Show resolved Hide resolved
styles/_theme.scss Outdated Show resolved Hide resolved
styles/_theme.scss Outdated Show resolved Hide resolved
styles/digitalocean/_code_environments.scss Outdated Show resolved Hide resolved
@MattIPv4 MattIPv4 changed the title Update code block theme colors Update color palette to match new design system Oct 16, 2023
@MattIPv4 MattIPv4 added enhancement New feature or request minor Change is SEMVER minor labels Oct 16, 2023
@MattIPv4
Copy link
Member

MattIPv4 commented Oct 16, 2023

Please also add a line to the unreleased changes in CHANGELOG.md with the change being made here ((minor) New design system colors for example)

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Changelog please

CHANGELOG.md Outdated Show resolved Hide resolved
@dbadea-heits dbadea-heits force-pushed the dbadea/code-block-styling branch 2 times, most recently from 0d8689c to c2597be Compare October 16, 2023 14:44
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the styling for the toolbar need updating to match the new design system?

styles/_highlight.scss Outdated Show resolved Hide resolved
styles/_highlight.scss Outdated Show resolved Hide resolved
@dbadea-heits dbadea-heits force-pushed the dbadea/code-block-styling branch 2 times, most recently from a73f037 to 5fe61f1 Compare October 17, 2023 07:57
@dbadea-heits
Copy link
Contributor Author

We dont have a toolbar designed for this @MattIPv4

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the files you've touched, could you make sure the copyright year is set to 2023 in the header?

styles/_code_prism.scss Outdated Show resolved Hide resolved
styles/_highlight.scss Outdated Show resolved Hide resolved
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattIPv4 MattIPv4 merged commit 900599c into digitalocean:master Oct 17, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor Change is SEMVER minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants