Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replicate issue: toJWK fails to be imported by JOSE lib #21

Open
vongohren opened this issue Nov 15, 2022 · 4 comments
Open

Replicate issue: toJWK fails to be imported by JOSE lib #21

vongohren opened this issue Nov 15, 2022 · 4 comments
Assignees
@aljones15

Comments

@vongohren
Copy link

I just wanted to raise awareness here as the issue is in a fork, and might be here as well.

digitalcredentials#5 (comment)
@vongohren
Copy link
Author

Checking in here if there are any thoughts of why this might happen?

@dmitrizagidulin
Copy link
Contributor

Found the cause -- the toJwk and fromJsonWebKey2020 methods have an error in their logic. See PR digitalcredentials#7 for fix.

@dlongley
Copy link
Member

dlongley commented Mar 24, 2023 •
edited
Loading

Looks like the fix here would be to ensure only the first 32 bytes are set as jwk.d.

https://github.com/digitalbazaar/ed25519-verification-key-2020/blob/main/lib/Ed25519VerificationKey2020.js#L316

@dlongley
Copy link
Member

We should add local interop tests with the jose lib as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dlongley @aljones15 @dmitrizagidulin @vongohren