feat: add --[no-]shell-escape flag #153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmke
force-pushed
the
feat/shell-escape
branch
from
d9e5b50 to
0f32231
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 71.32% 71.10% -0.23%
==========================================
Files 34 34
Lines 1859 1886 +27
==========================================
+ Hits 1326 1341 +15
- Misses 470 482 +12
Partials 63 63 ☔ View full report in Codecov by Sentry. |
dmke
force-pushed
the
feat/shell-escape
branch
from
0f32231 to
3c8d02f
Compare
dmke
force-pushed
the
feat/shell-escape
branch
from
3c8d02f to
998ab89
Compare
dmke
force-pushed
the
feat/shell-escape
branch
4 times, most recently
from
c08a977 to
d11b2c0
Compare
This allows or prohibits shell command execution from within TeX files.
The use case here is to allow users to download images from within the
build process, e.g. compiling something like this with `lualatex`:
\documentclass{article}
\usepackage{luacode}
\usepackage{graphicx}
\begin{document}
\begin{luacode*}
os.execute("curl -o apod.jpg https://apod.nasa.gov/apod/")
\end{luacode*}
\includegraphics{apod.jpeg}
\end{document}
To this end, I've included `curl` into the base image.
Fixes: #152
dmke
force-pushed
the
feat/shell-escape
branch
from
d11b2c0 to
5bdbbbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows or prohibits shell command execution from within TeX files.
TODO: Verify whether
latexmk -showextraoptionsmentions direct support for passing either flag. latexmk(1) does not, but has examples passing it via the-pdf{lua,xe,}latex="COMMAND"options. This would complicate the construction of the latexmk command.Fixes: #152