Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ensure audio link is embedded #307

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Fix audio file linking in inbox processing

When adding audio files (m4a, wav, etc.) to the inbox, the file is transcribed but the original audio file link was missing from the final note. This PR fixes the issue by:

  1. Using Obsidian's fileManager.generateMarkdownLink to create proper file links
  2. Adding proper type checking for both attachment and container files
  3. Maintaining the embedding functionality with the '!' prefix

The fix ensures that users can both read the transcription and access the original audio file from the same note.

Link to Devin run: https://app.devin.ai/sessions/e8c37e973c244fb291b01cd47f4a9c86

devin-ai-integration bot and others added 2 commits January 9, 2025 09:51
Co-Authored-By: alex@fileorganizer2000.com <alex@fileorganizer2000.com>
Co-Authored-By: alex@fileorganizer2000.com <alex@fileorganizer2000.com>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
file-organizer-2000-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 10:13am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
file-organizer-2000 ⬜️ Skipped (Inspect) Jan 9, 2025 10:13am

@vercel vercel bot temporarily deployed to Preview – file-organizer-2000 January 9, 2025 10:13 Inactive
@aexshafii aexshafii merged commit 4c262bb into master Jan 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant