Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file cache, increase test coverage #22

Merged
merged 30 commits into from
Feb 10, 2024
Merged

Add file cache, increase test coverage #22

merged 30 commits into from
Feb 10, 2024

Conversation

dickwolff
Copy link
Owner

@dickwolff dickwolff commented Jan 9, 2024 •
edited
Loading

Added

  • ✨ Introduced symbol cache, so subsequent runs don't have to request data from Yahoo Finance. This improves overall run speed
  • 📈 Improved test coverage of all remaining converters

Fixes

  • 🐛 Fixed unit price calculation for eToro

Fixes #21
Fixes #29

@dickwolff dickwolff added the Enhancement Request an enhancement to the tool label Jan 9, 2024
@dickwolff dickwolff mentioned this pull request Jan 9, 2024
Closed
@dickwolff dickwolff self-assigned this Jan 9, 2024
@dickwolff
Copy link
Owner Author

Need to test this change with the new beta degiro converter from #18

@dickwolff dickwolff mentioned this pull request Feb 9, 2024
Closed
@dickwolff dickwolff changed the title Add file cache Add file cache, increase test coverage Feb 10, 2024
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
src 76% 84% 0 ✔
src.converters 81% 75% 0 ✔
Summary 80% (511 / 638) 77% (248 / 322) 0 ✔

@dickwolff dickwolff merged commit fd073b8 into main Feb 10, 2024
2 checks passed
@dickwolff dickwolff deleted the feature/Add-File-Cache branch February 10, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dickwolff dickwolff

Labels
Enhancement Request an enhancement to the tool
Projects
None yet
Milestone
No milestone
1 participant
@dickwolff