Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISIN-Symbol override option #171

Merged
merged 9 commits into from
Jan 27, 2025
Merged

Add ISIN-Symbol override option #171

merged 9 commits into from
Jan 27, 2025

Conversation

dickwolff
Copy link
Owner

@dickwolff dickwolff commented Jan 27, 2025 •
edited
Loading

Added

  • ✨ Override the symbol for a specific ISIN, to have more control over the specific security you're looking for. For example override IE00B3RBWM25 to use VWRL.AS.

Fixes

Checklist

  • Added relevant changes to README (if applicable)
  • Added relevant test(s)
  • Updated GitVersion file and corresponding version in package.json

Related issue (if applicable)

Fixes #149

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
src 100% 100% 0 ✔
src.converters 97% 90% 0 ✔
src.helpers 100% 100% 0 ✔
Summary 97% (1539 / 1580) 91% (831 / 915) 0 ✔

@dickwolff dickwolff merged commit 4b87076 into main Jan 27, 2025
4 checks passed
@dickwolff dickwolff deleted the feat/Isin-Overrides branch January 27, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow manual ISIN overrides from the SecurityService
1 participant
@dickwolff