Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce wait time on yahoo for repeated ISIN numbers #21

Closed
Joren-vanGoethem opened this issue Jan 8, 2024 · 4 comments · Fixed by #22
Closed

reduce wait time on yahoo for repeated ISIN numbers #21

Joren-vanGoethem opened this issue Jan 8, 2024 · 4 comments · Fixed by #22
Assignees
Labels
Enhancement Request an enhancement to the tool

Comments

@Joren-vanGoethem
Copy link

add a local file or cache to save the found isin numbers to speed up conversion
cache only stays for the current run, file stays across runs

what do you think @dickwolff ?

@dickwolff
Copy link
Owner

Great suggestion. I have a cache of sorts in the current service but that does not work across multiple runs. Will look into that for sure!

@dickwolff dickwolff added the Enhancement Request an enhancement to the tool label Jan 8, 2024
@dickwolff
Copy link
Owner

@Joren-vanGoethem I added a cache solution in #22. The tool now stores it on disk and persists data between runs. On starting the tool, the data will be retrieved from cache and loaded in memory.

May need a more robust solution in the future if the cache becomes to large.

@dickwolff dickwolff self-assigned this Jan 9, 2024
@dickwolff
Copy link
Owner

dickwolff commented Jan 11, 2024

There was an issue with the TypeScript Map not being correctly processed and saved in cache. This is now resolved.

However there are now issues with retrieving symbols that are linked to the current "old" DEGIRO converter. This has to do with the way the current converter works with parsing records, and conflicting currencies. When #18 is merged, these issues should be resolved I believe.

@dickwolff
Copy link
Owner

dickwolff commented Feb 9, 2024

I have made the final changes to the cache in #22 , which should work now 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request an enhancement to the tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants