Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query generation only happen with test sets in QueryGenerator class #281

Open
sshivam95 opened this issue Nov 28, 2024 · 1 comment
Open

Comments

@sshivam95
Copy link
Contributor

In the method generate_queries, the mode should decide which edges should be passed to ground queries for getting queries and answers (as per the docstring). However, only test set is used. There is no functionality to use just the train or validation set.

sshivam95 added a commit that referenced this issue Nov 29, 2024
@sshivam95 sshivam95 changed the title Query gnereration only happen with test sets n QueryGenerator class Query generation only happen with test sets in QueryGenerator class Nov 29, 2024
sshivam95 added a commit that referenced this issue Nov 29, 2024
@Demirrr
Copy link
Member

Demirrr commented Nov 29, 2024

the mode should decide which edges should be passed to ground queries for getting queries and answers (as per the docstring).

What do you mean by the mode ?

However, only test set is used. There is no functionality to use just the train or validation set.

Since A KGE model is not trained on the query answer set, there is no train dataset is generated. Do you think that creating queries over train or validation set would be usefull ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants